Skip to content

Upgrade the snappy-java version to 1.1.10.7 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmuthukrishnan95
Copy link

fixes #12

java-snappy version is been upgraded to 1.1.10.7

https://github.com/xerial/snappy-java/releases/tag/v1.1.10.7

@mmuthukrishnan95
Copy link
Author

cc: @zac1st1k

@mmuthukrishnan95
Copy link
Author

Hello @KingMob and @slipset , Can you please review this PR ? Meanwhile build is failing to due to some environmental issue , Can you please help me on this ?

gpg: no valid OpenPGP data found.
gpg: Total number processed: 0

Exited with code exit status 2

@KingMob
Copy link
Collaborator

KingMob commented Feb 19, 2025

Hi @mmuthukrishnan95 , thanks for contributing this PR.

Before we approve, can you add a test that fails on the old snappy lib, and succeeds on the new version? The current tests don't catch this error.


If you were trying to ping Zach Tellman by @-ing zac1st1k, that's not him 😄 .

But regardless, Zach has long since moved on from byte-transforms and the whole Clojure community, so we don't usually involve him unless he's the only person on the planet who knows the answer to something.


Don't worry about the CI failure, since it's for deploying to clojars. Last deploy was 3 years ago, so it might have bitrotted.

@mmuthukrishnan95
Copy link
Author

@KingMob I can certainly write the new test cases for this. However, before proceeding, could you publish a dummy version of my changes and share the version details with me? This will allow me to verify the changes locally before finalizing the test cases.

@KingMob
Copy link
Collaborator

KingMob commented Feb 20, 2025

No need to publish globally.

If you need a different version of byte-transforms for testing in another project, you can update the byte-transforms version in project.clj to "0.2.2-SNAPSHOT" and run lein install, which will add it to your local maven lib (usually ~/.m2/). Then, in the other project, you'll depend on version "0.2.2-SNAPSHOT", which will use the local maven version.


If you want to override the version used, with leiningen, you can put [org.xerial.snappy/snappy-java "1.1.10.7"] ahead of the byte-streams dep, and it'll take precedence when resolving.

You can check what versions are ultimately used with lein deps :tree, lein deps :why, and lein classpath.


If you're using tools.deps, the resolution process is different, because it prioritizes newer versions, but you should still be able to override it for newer versions. Verification commands are clj -X:deps list and clj -X:deps tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Java 17 snappy requires access to java.nio.Buffer raw address field
2 participants